Re: [PATCH 7/7] target/mips: Undeprecate nanoMips ISA support in QEMU

[Philippe Mathieu-Daudé]

Hi Stefan,

On 4/5/22 13:04, Stefan Pejic wrote:
> nanoMips ISA support in QEMU is actively used by MediaTek and is
> planned to be maintained and potentially extended by MediaTek in
> future.
>
> Un-orphan nanoMips ISA support in QEMU by setting a mainainer from
> MediaTek and remove deprecation notes from documentation as well.
>
> Signed-off-by: Stefan Pejic <stefan.pejic@syrmia.com>
> ---
>   MAINTAINERS               |  3 ++-
>   docs/about/deprecated.rst | 26 --------------------------
>   2 files changed, 2 insertions(+), 27 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 294c88ace9..f1e0dee8a2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -240,7 +240,8 @@ F: docs/system/cpu-models-mips.rst.inc
>   F: tests/tcg/mips/
>   
>   MIPS TCG CPUs (nanoMIPS ISA)
> -S: Orphan
> +M: Stefan Pejic <stefan.pejic@syrmia.com>
> +S: Maintained
>   F: disas/nanomips.*
>   F: target/mips/tcg/*nanomips*
>   
> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> index 896e5a97ab..4b0868886f 100644
> --- a/docs/about/deprecated.rst
> +++ b/docs/about/deprecated.rst
> @@ -276,13 +276,6 @@ System emulator CPUS
>   ``Icelake-Client`` CPU Models are deprecated. Use ``Icelake-Server`` CPU
>   Models instead.
>   
> -MIPS ``I7200`` CPU Model (since 5.2)
> -''''''''''''''''''''''''''''''''''''
> -
> -The ``I7200`` guest CPU relies on the nanoMIPS ISA, which is deprecated
> -(the ISA has never been upstreamed to a compiler toolchain). Therefore
> -this CPU is also deprecated.
> -
>   
>   QEMU API (QAPI) events
>   ----------------------
> @@ -382,16 +375,6 @@ The above, converted to the current supported format::
>   
>     json:{"file.driver":"rbd", "file.pool":"rbd", "file.image":"name"}
>   
> -linux-user mode CPUs
> ---------------------
> -
> -MIPS ``I7200`` CPU (since 5.2)
> -''''''''''''''''''''''''''''''
> -
> -The ``I7200`` guest CPU relies on the nanoMIPS ISA, which is deprecated
> -(the ISA has never been upstreamed to a compiler toolchain). Therefore
> -this CPU is also deprecated.

Thanks for contributing all these fixes! I'm glad to see this code used
and soon maintained again. Last time I tried to run a user-mode binary
it wasn't loading due to incomplete nanoMIPS ABI support. What kind of
tests are you running? Would it be possible to contributing them, to 
avoid code bitrotting?

Thanks,

Phil.