Re: [PATCH 1/6] scsi-disk: add FORMAT UNIT command

[Philippe Mathieu-Daudé]

On 21/4/22 08:51, Mark Cave-Ayland wrote:
> When initialising a drive ready to install MacOS, Apple HD SC Setup first 
> attempts
> to format the drive. Add a simple FORMAT UNIT command which simply returns 
> success
> to allow the format to succeed.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
>   hw/scsi/scsi-disk.c  | 4 ++++
>   hw/scsi/trace-events | 1 +
>   2 files changed, 5 insertions(+)

> diff --git a/hw/scsi/trace-events b/hw/scsi/trace-events
> index 20fb0dc162..e91b55a961 100644
> --- a/hw/scsi/trace-events
> +++ b/hw/scsi/trace-events
> @@ -334,6 +334,7 @@ scsi_disk_emulate_command_UNMAP(size_t xfer) "Unmap (len 
> %zd)"
>   scsi_disk_emulate_command_VERIFY(int bytchk) "Verify (bytchk %d)"
>   scsi_disk_emulate_command_WRITE_SAME(int cmd, size_t xfer) "WRITE SAME %d (len 
> %zd)"
>   scsi_disk_emulate_command_UNKNOWN(int cmd, const char *name) "Unknown SCSI command 
> (0x%2.2x=%s)"
> +scsi_disk_emulate_command_FORMAT_UNIT(size_t xfer) "Format Unit (len %zd)"

%zu (%zd is for ssize_t), otherwise:

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>