Re: [PULL v2 75/86] include/hw/pci/pcie_host: Correct PCIE_MMCFG_SIZE_MAX

[Thomas Huth]

On 26/05/2022 17.54, BALATON Zoltan wrote:
> Hello,
>
> On Thu, 26 May 2022, Daniel Henrique Barboza wrote:
> > Hi,
> >
> > This patch broke the boot of the sam460ex ppc machine:
> >
> > qemu-system-ppc -M sam460ex -kernel 
> > ./buildroot/qemu_ppc_sam460ex-latest/vmlinux \
> > -device virtio-net-pci,netdev=net0 -netdev user,id=net0 -serial mon:stdio \
> > -nographic -snapshot
> > qemu-system-ppc: ../hw/pci/pcie_host.c:97: pcie_host_mmcfg_init: Assertion 
> > `size <= PCIE_MMCFG_SIZE_MAX' failed.
>
> Thanks for noticing this. I usually only test it during the freeze. Wasn't 
> there a test patch submitted by Philippe before? Isn't that yet merged or 
> included in CI? That should catch these before breaking it.

Seems like there is only the (primitive) boot-serial test so far:

$ grep -r sam460ex tests/
tests/qtest/boot-serial-test.c:    { "ppc", "sam460ex", "-m 256", "DRAM:  256 
MiB" },
tests/qtest/boot-serial-test.c:    { "ppc64", "sam460ex", "-device e1000", "8086  
100e" },

If there is a guest kernel available for public download somewhere,
it would be great if you could add an avocado test for this machine
(see e.g. the tests/avocado/ppc_*.py files for a template).

 Thomas