qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 15/17] linux-user/strace: Use is_error in print_syscall_er


From: Laurent Vivier
Subject: Re: [PATCH v5 15/17] linux-user/strace: Use is_error in print_syscall_err
Date: Sat, 28 May 2022 18:34:30 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0

Le 27/05/2022 à 18:48, Richard Henderson a écrit :
Errors are not all negative numbers: use is_error.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
  linux-user/strace.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/strace.c b/linux-user/strace.c
index 9fa681dea9..7d882526da 100644
--- a/linux-user/strace.c
+++ b/linux-user/strace.c
@@ -689,7 +689,7 @@ print_syscall_err(abi_long ret)
      const char *errstr;
qemu_log(" = ");
-    if (ret < 0) {
+    if (is_error(ret)) {
          errstr = target_strerror(-ret);
          if (errstr) {
              qemu_log("-1 errno=%d (%s)", (int)-ret, errstr);

Reviewed-by: Laurent Vivier <laurent@vivier.eu>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]