[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 03/17] target/m68k: Fix coding style in m68k_interrupt_all
From: |
Richard Henderson |
Subject: |
[PATCH v5 03/17] target/m68k: Fix coding style in m68k_interrupt_all |
Date: |
Fri, 27 May 2022 09:47:53 -0700 |
Add parenthesis around & vs &&.
Remove assignment to sr in function call argument -- note that
sr is unused after the call, so the assignment was never needed,
only the result of the & expression.
Suggested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/m68k/op_helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/m68k/op_helper.c b/target/m68k/op_helper.c
index 2b94a6ec84..0f41c2dce3 100644
--- a/target/m68k/op_helper.c
+++ b/target/m68k/op_helper.c
@@ -408,11 +408,11 @@ static void m68k_interrupt_all(CPUM68KState *env, int
is_hw)
break;
case EXCP_SPURIOUS ... EXCP_INT_LEVEL_7:
- if (is_hw && oldsr & SR_M) {
+ if (is_hw && (oldsr & SR_M)) {
do_stack_frame(env, &sp, 0, oldsr, 0, retaddr);
oldsr = sr;
env->aregs[7] = sp;
- cpu_m68k_set_sr(env, sr &= ~SR_M);
+ cpu_m68k_set_sr(env, sr & ~SR_M);
sp = env->aregs[7];
if (!m68k_feature(env, M68K_FEATURE_UNALIGNED_DATA)) {
sp &= ~1;
--
2.34.1
- [PATCH v5 00/17] target/m68k: Conditional traps + trap cleanup, Richard Henderson, 2022/05/27
- [PATCH v5 01/17] target/m68k: Raise the TRAPn exception with the correct pc, Richard Henderson, 2022/05/27
- [PATCH v5 03/17] target/m68k: Fix coding style in m68k_interrupt_all,
Richard Henderson <=
- [PATCH v5 04/17] linux-user/m68k: Handle EXCP_TRAP1 through EXCP_TRAP15, Richard Henderson, 2022/05/27
- [PATCH v5 05/17] target/m68k: Remove retaddr in m68k_interrupt_all, Richard Henderson, 2022/05/27
- [PATCH v5 06/17] target/m68k: Fix address argument for EXCP_CHK, Richard Henderson, 2022/05/27
- [PATCH v5 07/17] target/m68k: Fix pc, c flag, and address argument for EXCP_DIV0, Richard Henderson, 2022/05/27
- [PATCH v5 10/17] target/m68k: Implement TRAPcc, Richard Henderson, 2022/05/27