[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 08/15] qga: replace qemu_open_old() with qga_open_cloexec()
From: |
marcandre . lureau |
Subject: |
[PULL 08/15] qga: replace qemu_open_old() with qga_open_cloexec() |
Date: |
Fri, 27 May 2022 15:54:52 +0200 |
From: Marc-André Lureau <marcandre.lureau@redhat.com>
qemu_open_old() uses qemu_open_internal() which handles special
"/dev/fdset/" path for monitor fd sets, set CLOEXEC, and uses Error
reporting (and some O_DIRECT special error casing).
The monitor fdset handling is unnecessary for qga, use
qga_open_cloexec() instead.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Message-Id: <20220525144140.591926-9-marcandre.lureau@redhat.com>
---
qga/channel-posix.c | 13 +++++++++----
qga/commands-posix.c | 8 ++++----
2 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/qga/channel-posix.c b/qga/channel-posix.c
index 25fcc5cb1a..6796a02cff 100644
--- a/qga/channel-posix.c
+++ b/qga/channel-posix.c
@@ -1,8 +1,10 @@
#include "qemu/osdep.h"
+#include "qemu/cutils.h"
#include <termios.h>
#include "qapi/error.h"
#include "qemu/sockets.h"
#include "channel.h"
+#include "cutils.h"
#ifdef CONFIG_SOLARIS
#include <stropts.h>
@@ -127,11 +129,14 @@ static gboolean ga_channel_open(GAChannel *c, const gchar
*path,
switch (c->method) {
case GA_CHANNEL_VIRTIO_SERIAL: {
assert(fd < 0);
- fd = qemu_open_old(path, O_RDWR | O_NONBLOCK
+ fd = qga_open_cloexec(
+ path,
#ifndef CONFIG_SOLARIS
- | O_ASYNC
+ O_ASYNC |
#endif
- );
+ O_RDWR | O_NONBLOCK,
+ 0
+ );
if (fd == -1) {
error_setg_errno(errp, errno, "error opening channel");
return false;
@@ -156,7 +161,7 @@ static gboolean ga_channel_open(GAChannel *c, const gchar
*path,
struct termios tio;
assert(fd < 0);
- fd = qemu_open_old(path, O_RDWR | O_NOCTTY | O_NONBLOCK);
+ fd = qga_open_cloexec(path, O_RDWR | O_NOCTTY | O_NONBLOCK, 0);
if (fd == -1) {
error_setg_errno(errp, errno, "error opening channel");
return false;
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 2ecc43eca9..0047245273 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -1406,7 +1406,7 @@ static void get_nvme_smart(GuestDiskInfo *disk)
| (((sizeof(log) >> 2) - 1) << 16)
};
- fd = qemu_open_old(disk->name, O_RDONLY);
+ fd = qga_open_cloexec(disk->name, O_RDONLY, 0);
if (fd == -1) {
g_debug("Failed to open device: %s: %s", disk->name,
g_strerror(errno));
return;
@@ -1739,7 +1739,7 @@ int64_t qmp_guest_fsfreeze_freeze_list(bool
has_mountpoints,
}
}
- fd = qemu_open_old(mount->dirname, O_RDONLY);
+ fd = qga_open_cloexec(mount->dirname, O_RDONLY, 0);
if (fd == -1) {
error_setg_errno(errp, errno, "failed to open %s", mount->dirname);
goto error;
@@ -1806,7 +1806,7 @@ int64_t qmp_guest_fsfreeze_thaw(Error **errp)
QTAILQ_FOREACH(mount, &mounts, next) {
logged = false;
- fd = qemu_open_old(mount->dirname, O_RDONLY);
+ fd = qga_open_cloexec(mount->dirname, O_RDONLY, 0);
if (fd == -1) {
continue;
}
@@ -1892,7 +1892,7 @@ qmp_guest_fstrim(bool has_minimum, int64_t minimum, Error
**errp)
QAPI_LIST_PREPEND(response->paths, result);
- fd = qemu_open_old(mount->dirname, O_RDONLY);
+ fd = qga_open_cloexec(mount->dirname, O_RDONLY, 0);
if (fd == -1) {
result->error = g_strdup_printf("failed to open: %s",
strerror(errno));
--
2.36.1
- [PULL 00/15] Misc patches, marcandre . lureau, 2022/05/27
- [PULL 01/15] include: move qemu_*_exec_dir() to cutils, marcandre . lureau, 2022/05/27
- [PULL 02/15] util/win32: simplify qemu_get_local_state_dir(), marcandre . lureau, 2022/05/27
- [PULL 07/15] qga: throw an Error in ga_channel_open(), marcandre . lureau, 2022/05/27
- [PULL 10/15] test/qga: use G_TEST_DIR to locate os-release test file, marcandre . lureau, 2022/05/27
- [PULL 03/15] tests: make libqmp buildable for win32, marcandre . lureau, 2022/05/27
- [PULL 12/15] qga/wixl: require Mingw_bin, marcandre . lureau, 2022/05/27
- [PULL 13/15] qga/wixl: simplify some pre-processing, marcandre . lureau, 2022/05/27
- [PULL 14/15] qga/wixl: replace QEMU_GA_MSI_MINGW_BIN_PATH with glib bindir, marcandre . lureau, 2022/05/27
- [PULL 08/15] qga: replace qemu_open_old() with qga_open_cloexec(),
marcandre . lureau <=
- [PULL 11/15] qga/wixl: prefer variables over environment, marcandre . lureau, 2022/05/27
- [PULL 15/15] test/qga: use g_auto wherever sensible, marcandre . lureau, 2022/05/27
- [PULL 04/15] qga: flatten safe_open_or_create(), marcandre . lureau, 2022/05/27
- [PULL 05/15] qga: add qga_open_cloexec() helper, marcandre . lureau, 2022/05/27
- [PULL 06/15] qga: use qga_open_cloexec() for safe_open_or_create(), marcandre . lureau, 2022/05/27
- [PULL 09/15] qga: make build_fs_mount_list() return a bool, marcandre . lureau, 2022/05/27