Re: [PATCH 1/1] nbd: trace long NBD operations

[Denis V. Lunev]

On 27.05.2022 11:36, Vladimir Sementsov-Ogievskiy wrote:
> On 5/27/22 11:43, Denis V. Lunev wrote:
> > +++ b/nbd/client-connection.c
> > @@ -23,6 +23,7 @@
> >    */
> >     #include "qemu/osdep.h"
> > +#include "trace.h"
> >     #include "block/nbd.h"
> >   @@ -210,6 +211,7 @@ static void *connect_thread_func(void *opaque)
> >               object_unref(OBJECT(conn->sioc));
> >               conn->sioc = NULL;
> >               if (conn->do_retry && !conn->detached) {
> > +                trace_nbd_connect_iteration(timeout);
> >                   qemu_mutex_unlock(&conn->mutex);
> >                     sleep(timeout);
> > diff --git a/nbd/trace-events b/nbd/trace-events
> > index c4919a2dd5..bdadfdc82d 100644
> > --- a/nbd/trace-events
> > +++ b/nbd/trace-events
> > @@ -73,3 +73,6 @@ nbd_co_receive_request_decode_type(uint64_t handle, 
> > uint16_t type, const char *n
> >   nbd_co_receive_request_payload_received(uint64_t handle, uint32_t 
> > len) "Payload received: handle = %" PRIu64 ", len = %" PRIu32
> >   nbd_co_receive_align_compliance(const char *op, uint64_t from, 
> > uint32_t len, uint32_t align) "client sent non-compliant unaligned %s 
> > request: from=0x%" PRIx64 ", len=0x%" PRIx32 ", align=0x%" PRIx32
> >   nbd_trip(void) "Reading request"
> > +
> > +# client-connection.c
> > +nbd_connect_iteration(int in_flight) "timeout %d"
>
> timeout is uint64_t, so, it should be "uint64_t timeout" here and %" 
> PRIu64
Thanks! will change