Re: [PATCH v4 17/17] target/m68k: Mark helper_raise_exception as noreturn

[Richard Henderson]

On 5/25/22 12:45, Laurent Vivier wrote:
> > +DEF_HELPER_2(raise_exception, noreturn, env, i32)
...
> > -static void raise_exception_ra(CPUM68KState *env, int tt, uintptr_t raddr)
> > +G_NORETURN static void
> > +raise_exception_ra(CPUM68KState *env, int tt, uintptr_t raddr)
> >   {
> >       CPUState *cs = env_cpu(env);
> > @@ -540,7 +541,7 @@ static void raise_exception_ra(CPUM68KState *env, int tt, uintptr_t 
> > raddr)
> >       cpu_loop_exit_restore(cs, raddr);
> >   }
> > -static void raise_exception(CPUM68KState *env, int tt)
> > +G_NORETURN static void raise_exception(CPUM68KState *env, int tt)
> >   {
> >       raise_exception_ra(env, tt, 0);
> >   }
>
> And why not
>
>    G_NORETURN void HELPER(raise_exception)(CPUM68KState *env, uint32_t tt)
>
> ?

Because the declaration in the header file takes care of that.
No need to replicate it in the definition.


r~