[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 00/15] virtio-gpio and various virtio cleanups
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH v2 00/15] virtio-gpio and various virtio cleanups |
Date: |
Wed, 25 May 2022 17:14:15 +0100 |
On Tue, May 24, 2022 at 04:40:41PM +0100, Alex Bennée wrote:
> Hi,
>
> This series ostensibly adds virtio-user-gpio stubs to the build for
> use with an external vhost-user daemon. We've been testing it with our
> rust daemons from:
>
> https://github.com/rust-vmm/vhost-device
>
> Getting the test enabled took some doing most likely because the need
> for CONFIG support exercised additional paths in the code that were
> not used for the simpler virtio-net tests. As a result the series has
> a number of cleanup and documentation patches.
>
> The final thing that needed fixing was the ensuring that
> VHOST_USER_F_PROTOCOL_FEATURES didn't get squashed in the negotiation
> process. This was the hardest thing to track down as we store the
> feature bits in several places variously as:
>
> in VirtIODevice as:
> uint64_t guest_features;
> uint64_t host_features;
> uint64_t backend_features;
None of these know about VHOST_USER_F_PROTOCOL_FEATURES and vhost-user's
unfiltered feature bits should never be passed to VirtIODevice.
>
> in vhost_dev as:
> uint64_t features;
> uint64_t acked_features;
> uint64_t backend_features;
I don't think these should know about VHOST_USER_F_PROTOCOL_FEATURES
either. AFAIK vhost_dev deals with VIRTIO feature bits, not raw
vhost-user GET_FEATURES.
Stefan
signature.asc
Description: PGP signature
- [PATCH v2 11/15] tests/qtest: use g_autofree for test_server_create_chr, (continued)
- [PATCH v2 11/15] tests/qtest: use g_autofree for test_server_create_chr, Alex Bennée, 2022/05/24
- [PATCH v2 10/15] tests/qtest: catch unhandled vhost-user messages, Alex Bennée, 2022/05/24
- [PATCH v2 13/15] tests/qtest: implement stub for VHOST_USER_GET_CONFIG, Alex Bennée, 2022/05/24
- [PATCH v2 09/15] tests/qtest: use qos_printf instead of g_test_message, Alex Bennée, 2022/05/24
- [PATCH v2 12/15] tests/qtest: plain g_assert for VHOST_USER_F_PROTOCOL_FEATURES, Alex Bennée, 2022/05/24
- [PATCH v2 04/15] include/hw/virtio: document vhost_ack_features, Alex Bennée, 2022/05/24
- [PATCH v2 15/15] tests/qtest: enable tests for virtio-gpio, Alex Bennée, 2022/05/24
- [PATCH v2 14/15] tests/qtest: add a get_features op to vhost-user-test, Alex Bennée, 2022/05/24
- Re: [PATCH v2 00/15] virtio-gpio and various virtio cleanups,
Stefan Hajnoczi <=