Re: Problem running qos-test when building with gcc12 and LTO

[Alex Bennée]

Dario Faggioli <dfaggioli@suse.com> writes:

> [[PGP Signed Part:Undecided]]
> On Mon, 2022-05-23 at 19:19 +0000, Dario Faggioli wrote:
>> As soon as I get rid of _both_ "-flto=auto" _and_ "--enable-lto", the
>> above tests seem to work fine.
>> 
>> When they fail, they fail immediately, while creating the graph, like
>> this:
>> 
>> MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
>> QTEST_QEMU_IMG=./qemu-img G_TEST_DBUS_DAEMON=../tests/dbus-vmstate-
>> daemon.sh QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-
>> storage-daemon QTEST_QEMU_BINARY=./qemu-system-x86_64
>> ./tests/qtest/qos-test --tap -k
>> # random seed: R02S90d4b61102dd94459f986c2367d6d375
>> # starting QEMU: exec ./qemu-system-x86_64 -qtest unix:/tmp/qtest-
>> 28822.sock -qtest-log /dev/null -chardev socket,path=/tmp/qtest-
>> 28822.qmp,id=char0 -mon chardev=char0,mode=control -display none -
>> machine none -accel qtest
>> QOSStack: full stack, cannot pushAborted
>> 
> Ok, apparently, v6.2.0 works (with GCC 12 and LTO), while as said
> v7.0.0 doesn't.
>
> Therefore, I run a bisect, and it pointed at:
>
> 8dcb404bff6d9147765d7dd3e9c8493372186420
> tests/qtest: enable more vhost-user tests by default
>
> I've also confirmed that on v7.0.0 with 8dcb404bff6d914 reverted, the
> test actually works.
>
> As far as downstream packaging is concerned, I'll revert it locally.
> But I'd be happy to help figuring our what is actually going wrong.
>
> I'll try to dig further. Any idea/suggestion anyone has, feel free.
> :-)

Sounds like there are still memory corruption/not initialised issues
that are affected by moving things around.

Does it still trigger errors with my latest virtio cleanup series (which
adds more tests to qos-test):

  Subject: [PATCH  v2 00/15] virtio-gpio and various virtio cleanups
  Date: Tue, 24 May 2022 16:40:41 +0100
  Message-Id: <20220524154056.2896913-1-alex.bennee@linaro.org>


>
> Thanks and Regards


-- 
Alex Bennée