[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v4 13/36] i386/tdx: Validate TD attributes
From: |
Gerd Hoffmann |
Subject: |
Re: [RFC PATCH v4 13/36] i386/tdx: Validate TD attributes |
Date: |
Tue, 24 May 2022 08:59:59 +0200 |
On Tue, May 24, 2022 at 12:19:51PM +0800, Xiaoyao Li wrote:
> On 5/23/2022 5:39 PM, Gerd Hoffmann wrote:
> > So, how is this supposed to work? Patch #2 introduces attributes as
> > user-settable property. So do users have to manually figure and pass
> > the correct value, so the check passes? Specifically the fixed1 check?
> >
> > I think 'attributes' should not be user-settable in the first place.
> > Each feature-bit which is actually user-settable (and not already
> > covered by another option like pmu) should be a separate attribute for
> > tdx-object. Then the tdx code can create attributes from hardware
> > capabilities and user settings.
>
> In patch #2, tdx-guest.attributes is defined as a field to hold a 64 bits
> value of attributes but it doesn't provide any getter/setter for it. So it's
> *not* user-settable.
Ok. Why it is declared as object property in the first place then?
take care,
Gerd
[RFC PATCH v4 14/36] i386/tdx: Implement user specified tsc frequency, Xiaoyao Li, 2022/05/11
[RFC PATCH v4 16/36] i386/tdvf: Introduce function to parse TDVF metadata, Xiaoyao Li, 2022/05/11