qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] trivial: qga: Log version on start


From: Konstantin Kostiuk
Subject: Re: [PATCH] trivial: qga: Log version on start
Date: Mon, 23 May 2022 22:16:59 +0300



On Mon, May 23, 2022 at 8:35 PM Marc-André Lureau <marcandre.lureau@redhat.com> wrote:
On Mon, May 23, 2022 at 4:56 PM Konstantin Kostiuk <kkostiuk@redhat.com> wrote:
>
> Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>

why not, and why not QEMU_FULL_VERSION? :)

QEMU_FULL_VERSION is good too, no specific reason to use QEMU_VERSION.
 
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

> ---
>  qga/main.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/qga/main.c b/qga/main.c
> index 3b9546c185..a58368c75e 100644
> --- a/qga/main.c
> +++ b/qga/main.c
> @@ -1271,6 +1271,8 @@ static GAState *initialize_agent(GAConfig *config, int socket_activation)
>      g_log_set_fatal_mask(NULL, G_LOG_LEVEL_ERROR);
>      ga_enable_logging(s);
>
> +    g_debug("Guest agent version %s started", QEMU_VERSION);
> +
>  #ifdef _WIN32
>      /* On win32 the state directory is application specific (be it the default
>       * or a user override). We got past the command line parsing; let's create
> --
> 2.25.1
>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]