qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 23/49] semihosting: Split out semihost_sys_open


From: Richard Henderson
Subject: Re: [PATCH v3 23/49] semihosting: Split out semihost_sys_open
Date: Mon, 23 May 2022 11:21:46 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0

On 5/23/22 09:54, Peter Maydell wrote:
On Mon, 23 May 2022 at 16:46, Richard Henderson
<richard.henderson@linaro.org> wrote:
Also, I think I mentioned this in the v2 cover but not here, that having done 
the errno
conversion here for arm semihosting, it worked less well for mips and xtensa, 
which have a
rather better defined set of errnos.

My question from v2 was: should we in fact convert back from gdb's errno to 
host errno in
gdbstub.c handle_file_io(), and then let each semihosting backend convert from 
host to guest?

That sounds like it's probably a better idea (though I'm not sure
what host errno we use for the gdb "unknown errno" case)...

An excellent question. I note that both mips and xtensa use EINVAL when there is no exact match for the guest. It does seem to be the least bad option.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]