Re: [PATCH v3 36/49] gdbstub: Widen gdb_syscall_complete_cb return value

[Peter Maydell]

On Sat, 21 May 2022 at 01:04, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Always pass a uint64_t.  This resolves a FIXME in the
> m68k and nios2 semihosting that we've lost data.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  include/exec/gdbstub.h        |  3 +--
>  gdbstub.c                     |  7 ++++---
>  semihosting/arm-compat-semi.c |  9 ++++-----
>  semihosting/console.c         |  7 +++----
>  semihosting/syscalls.c        |  2 +-
>  target/m68k/m68k-semi.c       | 10 +++-------
>  target/nios2/nios2-semi.c     |  8 +++-----
>  7 files changed, 19 insertions(+), 27 deletions(-)


> -typedef void (*gdb_syscall_complete_cb)(CPUState *cpu,
> -                                        target_ulong ret, target_ulong err);
> +typedef void (*gdb_syscall_complete_cb)(CPUState *cpu, uint64_t ret, int 
> err);

Commit message says we're just changing the return value
handling, but the code also changes the type used for errno.

-- PMM