[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v4 03/36] target/i386: Implement mc->kvm_type() to get VM
From: |
Gerd Hoffmann |
Subject: |
Re: [RFC PATCH v4 03/36] target/i386: Implement mc->kvm_type() to get VM type |
Date: |
Mon, 23 May 2022 10:36:16 +0200 |
Hi,
> + if (!(kvm_check_extension(KVM_STATE(ms->accelerator), KVM_CAP_VM_TYPES)
> & BIT(kvm_type))) {
> + error_report("vm-type %s not supported by KVM",
> vm_type_name[kvm_type]);
> + exit(1);
> + }
Not sure why TDX needs a new vm type whereas sev doesn't. But that's up
for debate in the kernel tdx patches, not here. Assuming the kernel
interface actually merged will look like this the patch makes sense.
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
take care,
Gerd
- [RFC PATCH v4 00/36] TDX QEMU support, Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 01/36] *** HACK *** linux-headers: Update headers to pull in TDX API changes, Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 02/36] i386: Introduce tdx-guest object, Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 03/36] target/i386: Implement mc->kvm_type() to get VM type, Xiaoyao Li, 2022/05/11
- Re: [RFC PATCH v4 03/36] target/i386: Implement mc->kvm_type() to get VM type,
Gerd Hoffmann <=
- [RFC PATCH v4 04/36] target/i386: Introduce kvm_confidential_guest_init(), Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 05/36] i386/tdx: Implement tdx_kvm_init() to initialize TDX VM context, Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 06/36] i386/tdx: Get tdx_capabilities via KVM_TDX_CAPABILITIES, Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 07/36] i386/tdx: Introduce is_tdx_vm() helper and cache tdx_guest object, Xiaoyao Li, 2022/05/11