qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] virtio_balloon: Introduce memory recover


From: kernel test robot
Subject: Re: [PATCH 3/3] virtio_balloon: Introduce memory recover
Date: Fri, 20 May 2022 21:39:32 +0800

Hi zhenwei,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on next-20220519]
[cannot apply to linux/master linus/master v5.18-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/intel-lab-lkp/linux/commits/zhenwei-pi/recover-hardware-corrupted-page-by-virtio-balloon/20220520-151328
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git 
mm-everything
config: nios2-randconfig-r002-20220519 
(202205202151.7T3K7Szf-lkp@intel.com/config">https://download.01.org/0day-ci/archive/20220520/202205202151.7T3K7Szf-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # 
https://github.com/intel-lab-lkp/linux/commit/a42127073dd4adb6354649c8235c5cde033d01f2
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review 
zhenwei-pi/recover-hardware-corrupted-page-by-virtio-balloon/20220520-151328
        git checkout a42127073dd4adb6354649c8235c5cde033d01f2
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 
O=build_dir ARCH=nios2 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   nios2-linux-ld: drivers/virtio/virtio_balloon.o: in function 
`unpoison_memory_func':
>> drivers/virtio/virtio_balloon.c:679: undefined reference to `unpoison_memory'
   drivers/virtio/virtio_balloon.c:679:(.text+0xc00): relocation truncated to 
fit: R_NIOS2_CALL26 against `unpoison_memory'
   nios2-linux-ld: drivers/virtio/virtio_balloon.o: in function 
`virtballoon_probe':
>> drivers/virtio/virtio_balloon.c:1247: undefined reference to 
>> `register_memory_failure_notifier'
   drivers/virtio/virtio_balloon.c:1247:(.text+0x1940): relocation truncated to 
fit: R_NIOS2_CALL26 against `register_memory_failure_notifier'
   nios2-linux-ld: drivers/virtio/virtio_balloon.o: in function 
`virtballoon_remove':
>> drivers/virtio/virtio_balloon.c:1323: undefined reference to 
>> `unregister_memory_failure_notifier'
   drivers/virtio/virtio_balloon.c:1323:(.text+0x1bcc): relocation truncated to 
fit: R_NIOS2_CALL26 against `unregister_memory_failure_notifier'


vim +679 drivers/virtio/virtio_balloon.c

   661  
   662  static void unpoison_memory_func(struct work_struct *work)
   663  {
   664          struct virtio_balloon *vb;
   665          struct page *page;
   666  
   667          vb = container_of(work, struct virtio_balloon, 
unpoison_memory_work);
   668  
   669          do {
   670                  spin_lock(&vb->recover_page_list_lock);
   671                  page = 
list_first_entry_or_null(&vb->recovered_page_list,
   672                                                  struct page, lru);
   673                  if (page)
   674                          list_del(&page->lru);
   675                  spin_unlock(&vb->recover_page_list_lock);
   676  
   677                  if (page) {
   678                          put_page(page);
 > 679                          unpoison_memory(page_to_pfn(page), true, 
 > "virtio-balloon");
   680                  }
   681          } while (page);
   682  }
   683  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp



reply via email to

[Prev in Thread] Current Thread [Next in Thread]