Re: [PULL 0/8] Misc patches (Gitlab-CI, qtest, Capstone, ...)

[Daniel P . Berrangé]

On Thu, May 19, 2022 at 08:29:09AM +0200, Thomas Huth wrote:
> On 18/05/2022 18.12, Richard Henderson wrote:
> > On 5/18/22 02:04, Thomas Huth wrote:
> > >   Hi Richard!
> > > 
> > > The following changes since commit 
> > > eec398119fc6911d99412c37af06a6bc27871f85:
> > > 
> > >    Merge tag 'for_upstream' of
> > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu into staging
> > > (2022-05-16 16:31:01 -0700)
> > > 
> > > are available in the Git repository at:
> > > 
> > >    https://gitlab.com/thuth/qemu.git tags/pull-request-2022-05-18
> > > 
> > > for you to fetch changes up to 83602083b4ada6ceb86bfb327e83556ebab120fc:
> > > 
> > >    capstone: Remove the capstone submodule (2022-05-18 08:54:22 +0200)
> > > 
> > > ----------------------------------------------------------------
> > > * Remove Ubuntu 18.04 containers (not supported anymore)
> > > * Improve the cleanup of the QEMU binary in case of failing qtests
> > > * Update the Windows support statement
> > > * Remove the capstone submodule (and rely on Capstone of the distros 
> > > instead)
> > 
> > Fails centos-stream-8-x86_64 test,
> > 
> > Run-time dependency capstone found: NO (tried pkgconfig)
> > ../meson.build:2539:2: ERROR: Dependency "capstone" not found, tried 
> > pkgconfig
> > 
> > https://gitlab.com/qemu-project/qemu/-/jobs/2473935684
> 
> That's a custom runner ... who has access to that one? Cleber? Stefan? I
> didn't spot an entry for it on https://wiki.qemu.org/AdminContacts ...
> 
> Anyway, somebody needs to install "capstone-devel" on that machine - or we
> need to disable capstone in scripts/ci/org.centos/stream/8/x86_64/configure
> now if the machine can't be changed...

This is pretty that when we add build deps we need someone to manually
inconvenient as a requirement :-(

It would be really nice if the host could run the jobs in containers,
so when the pull request contains container updates, it "just works"
in the same way as the standard gitlab runners.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|