qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser


From: Thomas Huth
Subject: Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser
Date: Thu, 19 May 2022 08:41:16 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0

On 18/05/2022 17.41, Eric Blake wrote:
On Wed, May 18, 2022 at 03:44:45PM +0200, Thomas Huth wrote:
The "-display sdl" option still uses a hand-crafted parser for its
parameters since we didn't want to drag an interface we considered
somewhat flawed into the QAPI schema. Since the flaws are gone now,
it's time to QAPIfy.

This introduces the new "DisplaySDL" QAPI struct that is used to hold
the parameters that are unique to the SDL display. The only specific
parameter is currently "grab-mod" that is used to specify the required
modifier keys to escape from the mouse grabbing mode.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---

+++ b/qapi/ui.json
@@ -1295,6 +1295,30 @@
        '*swap-opt-cmd': 'bool'
    } }
+##
+# @GrabMod:
+#
+# Set of modifier keys that need to be hold for shortcut key actions.

s/hold/held/

Thanks, I'll send a v3 with this (and the nits found by Markus) fixed.

 Thomas





reply via email to

[Prev in Thread] Current Thread [Next in Thread]