Re: [PATCH v5 8/8] libvduse: Add support for reconnecting

[Stefan Hajnoczi]

On Wed, May 04, 2022 at 03:40:51PM +0800, Xie Yongji wrote:
> @@ -291,6 +294,15 @@ static int vduse_blk_exp_create(BlockExport *exp, 
> BlockExportOptions *opts,
>          return -ENOMEM;
>      }
>  
> +    vblk_exp->recon_file = g_strdup_printf("%s/vduse-blk-%s",
> +                                           g_get_tmp_dir(), exp->id);

g_get_tmp_dir() returns the $TMPDIR environment variable. This means
exp->id must be unique across the host. Please document this.

Thanks,
Stefan

signature.asc
Description: PGP signature