Re: [PATCH v22 3/7] net/vmnet: implement shared mode (vmnet-shared)

[osy]

On Thu, Mar 17, 2022 at 10:28 AM Vladislav Yaroshchuk
<vladislav.yaroshchuk@jetbrains.com> wrote:
>
> Interaction with vmnet.framework in different modes
> differs only on configuration stage, so we can create
> common `send`, `receive`, etc. procedures and reuse them.
>
> Signed-off-by: Phillip Tennen <phillip@axleos.com>
> Signed-off-by: Vladislav Yaroshchuk <Vladislav.Yaroshchuk@jetbrains.com>
> Reviewed-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> Tested-by: Akihiko Odaki <akihiko.odaki@gmail.com>

Hi Vladislav,

Thanks for the patches. We ran into an issue integrating it into UTM
when we discovered that by targeting a lower macOS version (we like to
have one binary for all macOS versions), newer features were compiled
out. This commit resolves that and we think it would be beneficial to
others as well. Since it does not appear the submission has made it to
mainline yet, it could be integrated into your patchset.

https://github.com/utmapp/qemu/commit/6626058f225c9c6a402f9ac6f90aa0b7e94d175c

Thank you!