Re: [PATCH 34/35] tests: acpi: update expected DSDT.tis.tpm2/DSDT.tis.tpm12 blobs

[Ani Sinha]

On Mon, May 16, 2022 at 8:57 PM Igor Mammedov <imammedo@redhat.com> wrote:
>
> expected move of tmp-tis device description directly under
> Device(ISA) node.
>
> for tpm-tis 2.0:
>
>   @@ -145,6 +145,189 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC    ", 
> 0x00000001)
>            {
>                Name (_ADR, 0x001F0000)  // _ADR: Address
>                OperationRegion (PIRQ, PCI_Config, 0x60, 0x0C)
>   +            Device (TPM)
>   +            {
>   +                Name (_HID, "MSFT0101" /* TPM 2.0 Security Device */)  // 
> _HID: Hardware ID
>   +                Name (_STR, "TPM 2.0 Device")  // _STR: Description String
>   +                Name (_UID, One)  // _UID: Unique ID
>   +                Name (_STA, 0x0F)  // _STA: Status
>     ...
>   +            }
>
>   @@ -3281,189 +3464,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC    
> ", 0x00000001)
>                Method (PCNT, 0, NotSerialized)
>                {
>                }
>   -
>   -            Device (TPM)
>   -            {
>   -                Name (_HID, "MSFT0101" /* TPM 2.0 Security Device */)  // 
> _HID: Hardware ID
>   -                Name (_STR, "TPM 2.0 Device")  // _STR: Description String
>   -                Name (_UID, One)  // _UID: Unique ID
>   -                Name (_STA, 0x0F)  // _STA: Status
>     ...
>   -            }
>
> for tpm-tis 1.2:
>
>   @@ -145,6 +145,188 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC    ", 
> 0x00000001)
>            {
>                Name (_ADR, 0x001F0000)  // _ADR: Address
>                OperationRegion (PIRQ, PCI_Config, 0x60, 0x0C)
>   +            Device (TPM)
>   +            {
>   +                Name (_HID, EisaId ("PNP0C31"))  // _HID: Hardware ID
>   +                Name (_UID, One)  // _UID: Unique ID
>   +                Name (_STA, 0x0F)  // _STA: Status
>     ...
>   +            }
>
>   @@ -3281,188 +3463,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC    
> ", 0x00000001)
>                Method (PCNT, 0, NotSerialized)
>                {
>                }
>   -
>   -            Device (ISA.TPM)
>   -            {
>   -                Name (_HID, EisaId ("PNP0C31"))  // _HID: Hardware ID
>   -                Name (_UID, One)  // _UID: Unique ID
>   -                Name (_STA, 0x0F)  // _STA: Status
>     ...
>   -            }
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>

Acked-by: Ani Sinha <ani@anisinha.ca>

> ---
>  tests/qtest/bios-tables-test-allowed-diff.h |   2 --
>  tests/data/acpi/q35/DSDT.tis.tpm12          | Bin 8885 -> 8880 bytes
>  tests/data/acpi/q35/DSDT.tis.tpm2           | Bin 8906 -> 8906 bytes
>  3 files changed, 2 deletions(-)
>
> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h 
> b/tests/qtest/bios-tables-test-allowed-diff.h
> index 7b3bf9a207..dfb8523c8b 100644
> --- a/tests/qtest/bios-tables-test-allowed-diff.h
> +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> @@ -1,3 +1 @@
>  /* List of comma-separated changed AML files to ignore */
> -"tests/data/acpi/q35/DSDT.tis.tpm2",
> -"tests/data/acpi/q35/DSDT.tis.tpm12",
> diff --git a/tests/data/acpi/q35/DSDT.tis.tpm12 
> b/tests/data/acpi/q35/DSDT.tis.tpm12
> index 
> 0b5c97fdb5da8b7b55d6b5f2af498a447fda7bf8..a97d884c50485f848054c6ac95ecfa055ff59e5b
>  100644
> GIT binary patch
> delta 89
> zcmdn$y1|vpCD<iogAxM+quxfYn~XZHW_t0#PVoWGo(9oP9;Tkbj`1AvjxIqw3=HxN
> r(G3BfL4izM30yqUO%AG?(-r)fHghwv%5nLz#DKI3xUo!@Qg8tPLai3C
>
> delta 95
> zcmdnsy497-CD<ios}chP<Nl3YHyJgY1@+>Co#F$WJq@Cp+yp#>9pgFT9bJNW7#QRk
> vq8kD{g94ej61aFa$Fi`>ak*;6fK&_kYEI5ka^Z|_a#hs>Y1z!r<i`X6>g5>c
>
> diff --git a/tests/data/acpi/q35/DSDT.tis.tpm2 
> b/tests/data/acpi/q35/DSDT.tis.tpm2
> index 
> 4e16b126cc1c32f2346078fa69c5261c245d15e8..1f5392919b5ea69696b49ff13aab5c37d0615919
>  100644
> GIT binary patch
> delta 85
> zcmX@*ddii{CD<k8loA62<JFB^HyJhj&Gq7go#F$WJq@CpoXkCg9pgFT9bJNW7#QRk
> nq8kD{g94ej61aFa$0_76ZRTcTmE-bbi2-R5aATP)rQiYpDU=p=
>
> delta 85
> zcmX@*ddii{CD<k8loA62<CBeCHyJgY1@+>Co#F$WJq@Cp+yp#>9pgFT9bJNW7#QRk
> nq8kD{g94ej61aFam$R_Sad~OSfK&@OX-{rba@owyl*0r7A8!`n
>
> --
> 2.31.1
>