Re: [PATCH v2] gitlab-ci: Switch the container of the 'check-patch' & 'check-dco' jobs

[John Snow]

On Mon, May 16, 2022 at 4:26 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Mon, May 16, 2022 at 10:23:10AM +0200, Thomas Huth wrote:
> > The 'check-patch' and 'check-dco' jobs only need Python and git for
> > checking the patches, so it's not really necessary to use a container
> > here that has all the other build dependencies installed. By using a
> > lightweight Alpine container, we can improve the runtime here quite a
> > bit, cutting it down from ca. 1:30 minutes to ca. 45 seconds.
> >
> > Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> >  v2: Use python:alpine for even quicker execution
> >
> >  .gitlab-ci.d/static_checks.yml | 14 ++++++++------
> >  1 file changed, 8 insertions(+), 6 deletions(-)
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>

Looks good.

Sorry for fooling you with my python container -- I am using it to
ensure a very wide spectrum of version compatibility.

Reviewed-by: John Snow <jsnow@redhat.com>