|
From: | Richard Henderson |
Subject: | Re: [PATCH v2 68/74] hw/rx: Handle a kernel file that is ELF |
Date: | Fri, 13 May 2022 09:40:00 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 |
On 5/13/22 08:48, Richard Henderson wrote:
On 5/13/22 08:44, Peter Maydell wrote:On Tue, 3 May 2022 at 21:52, Richard Henderson <richard.henderson@linaro.org> wrote:Attempt to load the kernel with load_elf. If this fails with ELF_LOAD_NOT_ELF, continue to treat the kernel as a raw image. This will be handy for running semihosting programs. Signed-off-by: Richard Henderson <richard.henderson@linaro.org>I know nothing of the specifics of the rx target, but I'm always a bit dubious about adding more behaviour to the -kernel option, which is (a) already a morass of undocumented target specific behaviours (b) nominally supposed to be "load a Linux kernel", not "load any random thing". Can you do what you need with the generic-loader device instead? That has the benefit of both being documented and also doing the same thing on all target architectures.I'll give that a try.
It works, editing the board not to reject lack of -bios and lack of -kernel. And running by hand because the syntax of the test harness does not allow the test file to be joined with $(QEMU_OPTS), as in
-device loader,cpu-num=0,file=testcase I'll work with Alex to figure out how best to restructure the test harness.In the meantime I certainly don't mind putting the rx part on the back burner if it'll help get the previous 67 patches reviewed...
r~
[Prev in Thread] | Current Thread | [Next in Thread] |