qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 6/9] tests: add check-venv as a dependency of check and c


From: John Snow
Subject: Re: [RFC PATCH 6/9] tests: add check-venv as a dependency of check and check-block
Date: Fri, 13 May 2022 12:08:48 -0400



On Fri, May 13, 2022, 11:34 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
On 5/13/22 16:12, John Snow wrote:
>
>     I think you need instead:
>
>     # The do-meson-check and do-meson-bench targets are defined in
>     Makefile.mtest
>     do-meson-check do-meson-bench: check-venv
>
>     and I would even add "all" to the targets that create the virtual
>     environment.
>
>     Paolo
>
>
> Great, thanks! I'll try that out today.

Well, check out the other suggestion of creating the venv at configure
time, because that would remove all these complications/annoyances.

Paolo

They also raise new annoyances and questions for me, so it might be worth updating this "branch" of the patchset to have a basis of comparison for what's the least annoying in the end.

(Or maybe even to serve as a basis while transitioning to the "better" solution. It's quick to try, at least.)

Config script ideas are gonna take me a bit longer to work through.

(I'm not against developing a minimum viable patchset and having you tweak it to your desire afterwards, if you have the time/interest. We can chat on irc if you'd like. Otherwise, I'll just push forward.)

--js

reply via email to

[Prev in Thread] Current Thread [Next in Thread]