Re: [PATCH v2 1/8] qmp: Support for querying stats

[Markus Armbruster]

Paolo Bonzini <pbonzini@redhat.com> writes:

> On 5/13/22 14:52, Markus Armbruster wrote:
>>> +# @StatsResult:
>>> +#
>>> +# @provider: provider for this set of statistics.
>>> +# @qom-path: QOM path of the object for which the statistics are returned
>> Since @qom-path is optional, we better document when it's present.  In
>> the review thread for v1, you explained "Only if the target is vcpus,
>> for the current set of targets."  More general, and hopefully still
>> correct, would be "Present if that object is a QOM object", but the
>> phrasing feels rather clumsy.  Would appending ", if any" suffice?
>> 
>
> Alternatively:
>
> # @qom-path: Path to the object for which the statistics are returned,
> #            if the object is exposed in the QOM tree

Sold!