Re: [RFC PATCH 4/9] tests: silence pip upgrade warnings during venv creation

[Paolo Bonzini]

On 5/13/22 02:06, John Snow wrote:
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index dbbf1ba535b..dfb678d379f 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -109,11 +109,11 @@ $(TESTS_VENV_DIR): $(TESTS_VENV_REQ) 
> $(SRC_PATH)/python/setup.cfg
>              $(PYTHON) -m venv $@, \
>              VENV, $@)
>         $(call quiet-command, \
> -            $(TESTS_PYTHON) -m pip -q install \
> +            $(TESTS_PYTHON) -m pip -q --disable-pip-version-check install \
>              -e "$(SRC_PATH)/python/", PIP, "$(SRC_PATH)/python/")
>         $(call quiet-command, \
> -            $(TESTS_PYTHON) -m pip -q install -r $(TESTS_VENV_REQ), \
> -            PIP, $(TESTS_VENV_REQ))
> +            $(TESTS_PYTHON) -m pip -q --disable-pip-version-check install \
> +            -r $(TESTS_VENV_REQ), PIP, $(TESTS_VENV_REQ))
>         $(call quiet-command, touch $@)

Really nitpicking but I would have placed this change before adding the 
second invocation of pip. :)

Paolo