Re: [PATCH v5 17/21] migration: Export tls-[creds|hostname|authz] params to cmdline too

[Peter Xu]

On Thu, May 12, 2022 at 08:05:45PM +0100, Daniel P. Berrangé wrote:
> > > @@ -4372,12 +4375,9 @@ static void migration_class_init(ObjectClass 
> > > *klass, void *data)
> > >  static void migration_instance_finalize(Object *obj)
> > >  {
> > >      MigrationState *ms = MIGRATION_OBJ(obj);
> > > -    MigrationParameters *params = &ms->parameters;
> > >  
> > >      qemu_mutex_destroy(&ms->error_mutex);
> > >      qemu_mutex_destroy(&ms->qemu_file_lock);
> > > -    g_free(params->tls_hostname);
> > > -    g_free(params->tls_creds);
> > 
> > So hmm, why is tls-authz special here?
> 
> Pre-existing memory leak bug IIUC

Right, and there's one extra paragraph in commit message explaining it (per
Dan's request):

  This also fixes a trivial memory leak for tls-authz as we forgot to free it
  before this patch.

Thanks,

-- 
Peter Xu