[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qapi: make machine type deprecation a warning
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH] qapi: make machine type deprecation a warning |
Date: |
Thu, 12 May 2022 13:53:49 +0100 |
User-agent: |
Mutt/2.2.1 (2022-02-19) |
On Thu, May 12, 2022 at 02:24:35PM +0200, Paolo Bonzini wrote:
> On 5/12/22 12:46, Markus Armbruster wrote:
> > Commit message nitpick: not sure this is "qapi:". The commit that
> > introduced "Machine type ... is deprecated" (08fe68244eb) used
> > "hw/i386:". We commonly use "vl:", "softmmu:", and "softmmu/vl:" for
> > this file.
>
> Will do.
>
> I wonder if I should already propose renaming vl.c to climain.c, even if
> there's no qmpmain.c yet. Emotional/historical attachment is probably not
> good enough of a reason to keep that name.
>
> I suppose this is already a proposal.
For all the othe tools we just use the filename $TOOL.c, eg qemu-img.c,
etc. So what about qemu-system.c
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|