Re: [PATCH v2 8/8] qapi: Stop using whitespace for alignment in comments

[Markus Armbruster]

Eric Blake <eblake@redhat.com> writes:

> On Tue, May 03, 2022 at 09:37:37AM +0200, Andrea Bolognani wrote:
>> Perfectly aligned things look pretty, but keeping them that
>> way as the schema evolves requires churn, and in some cases
>> newly-added lines are not aligned properly.
>> 
>> Overall, trying to align things is just not worth the trouble.
>
> I'm in favor of commiting 7+8 squashed as a single patch.  7 alone is
> indeed a churn magnet, so I'm either for stopping the series at 6, or
> going all the way to 8 via a single additional step.

Understood.

Diffstat for 7+8:

 qapi/block-core.json | 53 ++++++++++++++++++++++++++--------------------------
 qapi/block.json      |  6 +++---
 qapi/char.json       |  6 +++---
 qapi/control.json    | 10 +++++-----
 qapi/crypto.json     | 42 ++++++++++++++++++++---------------------
 qapi/migration.json  |  8 ++++----
 qapi/sockets.json    |  4 ++--
 qapi/ui.json         | 17 ++++++++---------
 8 files changed, 72 insertions(+), 74 deletions(-)

Considering we have >16k comment lines in qapi/*json, the churn feels
quite tolerable.

> Reviewed-by: Eric Blake <eblake@redhat.com>

Last call for objections: Kevin, Hanna, Gerd?