[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v2 4/8] net: stream: Don't ignore EINVAL on netdev socket
From: |
Daniel P . Berrangé |
Subject: |
Re: [RFC PATCH v2 4/8] net: stream: Don't ignore EINVAL on netdev socket connection |
Date: |
Thu, 12 May 2022 09:39:15 +0100 |
User-agent: |
Mutt/2.2.1 (2022-02-19) |
On Thu, May 12, 2022 at 10:09:28AM +0200, Laurent Vivier wrote:
> From: Stefano Brivio <sbrivio@redhat.com>
>
> Other errors are treated as failure by net_stream_client_init(),
> but if connect() returns EINVAL, we'll fail silently. Remove the
> related exception.
>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
> [lvivier: applied to net/stream.c]
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> net/stream.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [RFC PATCH v2 0/8] qapi: net: add unix socket type support to netdev backend, Laurent Vivier, 2022/05/12
- [RFC PATCH v2 4/8] net: stream: Don't ignore EINVAL on netdev socket connection, Laurent Vivier, 2022/05/12
- Re: [RFC PATCH v2 4/8] net: stream: Don't ignore EINVAL on netdev socket connection,
Daniel P . Berrangé <=
- [RFC PATCH v2 5/8] net: stream: add unix socket, Laurent Vivier, 2022/05/12
- [RFC PATCH v2 3/8] qapi: net: add stream and dgram netdevs, Laurent Vivier, 2022/05/12
- [RFC PATCH v2 6/8] net: dgram: make dgram_dst generic, Laurent Vivier, 2022/05/12
- [RFC PATCH v2 1/8] net: introduce convert_host_port(), Laurent Vivier, 2022/05/12
- [RFC PATCH v2 2/8] qapi: net: introduce a way to bypass qemu_opts_parse_noisily(), Laurent Vivier, 2022/05/12
- [RFC PATCH v2 7/8] net: dgram: move mcast specific code from net_socket_fd_init_dgram(), Laurent Vivier, 2022/05/12
- [RFC PATCH v2 8/8] net: dgram: add unix socket, Laurent Vivier, 2022/05/12
- Re: [RFC PATCH v2 0/8] qapi: net: add unix socket type support to netdev backend, Stefano Brivio, 2022/05/13