[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 4/6] net: socket-ng: make dgram_dst generic
From: |
Stefano Brivio |
Subject: |
Re: [RFC PATCH 4/6] net: socket-ng: make dgram_dst generic |
Date: |
Tue, 10 May 2022 23:24:51 +0200 |
On Mon, 9 May 2022 19:36:16 +0200
Laurent Vivier <lvivier@redhat.com> wrote:
> dgram_dst is a sockaddr_in structure. To be able to use it with
> unix socket, use a pointer to a generic sockaddr structure.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> net/socket-ng.c | 76 ++++++++++++++++++++++++++++++-------------------
> 1 file changed, 46 insertions(+), 30 deletions(-)
>
> diff --git a/net/socket-ng.c b/net/socket-ng.c
> index 2c70440a2b57..0056924dc02b 100644
> --- a/net/socket-ng.c
> +++ b/net/socket-ng.c
>
> [...]
>
> @@ -903,13 +918,14 @@ static int net_socketng_udp_init(NetClientState *peer,
> }
>
> if (remote) {
> - s->dgram_dst = raddr_in;
> + g_assert(s->dgram_dst == NULL);
> + s->dgram_dst = dgram_dst;
>
> pstrcpy(s->nc.info_str, sizeof(s->nc.info_str), info_str);
> g_free(info_str);
> }
> return 0;
> -}
> +};
Stray semicolon (I guess not reported by gcc without -pedantic).
--
Stefano
- [RFC PATCH 0/6] qapi: net: add unix socket type support to netdev backend, Laurent Vivier, 2022/05/09
- [RFC PATCH 4/6] net: socket-ng: make dgram_dst generic, Laurent Vivier, 2022/05/09
- Re: [RFC PATCH 4/6] net: socket-ng: make dgram_dst generic,
Stefano Brivio <=
- [RFC PATCH 3/6] net: socket-ng: add unix socket for server and client mode., Laurent Vivier, 2022/05/09
- [RFC PATCH 2/6] qapi: net: add socket-ng netdev, Laurent Vivier, 2022/05/09
- [RFC PATCH 6/6] net: socket-ng: add unix socket for dgram mode, Laurent Vivier, 2022/05/09
- [RFC PATCH 5/6] net: socket-ng: move mcast specific code from net_socket_fd_init_dgram(), Laurent Vivier, 2022/05/09
- [RFC PATCH 1/6] net: introduce convert_host_port(), Laurent Vivier, 2022/05/09
- Re: [RFC PATCH 0/6] qapi: net: add unix socket type support to netdev backend, Daniel P . Berrangé, 2022/05/10