[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 3/7] vhost-vdpa: fix improper cleanup in net_init_vhost_vdpa
From: |
Si-Wei Liu |
Subject: |
[PATCH v4 3/7] vhost-vdpa: fix improper cleanup in net_init_vhost_vdpa |
Date: |
Fri, 6 May 2022 19:28:14 -0700 |
... such that no memory leaks on dangling net clients in case of
error.
Signed-off-by: Si-Wei Liu <si-wei.liu@oracle.com>
Acked-by: Jason Wang <jasowang@redhat.com>
---
net/vhost-vdpa.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 1e9fe47..df1e69e 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -306,7 +306,9 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char
*name,
err:
if (i) {
- qemu_del_net_client(ncs[0]);
+ for (i--; i >= 0; i--) {
+ qemu_del_net_client(ncs[i]);
+ }
}
qemu_close(vdpa_device_fd);
--
1.8.3.1
- [PATCH v4 0/7] vhost-vdpa multiqueue fixes, Si-Wei Liu, 2022/05/06
- [PATCH v4 1/7] virtio-net: setup vhost_dev and notifiers for cvq only when feature is negotiated, Si-Wei Liu, 2022/05/06
- [PATCH v4 3/7] vhost-vdpa: fix improper cleanup in net_init_vhost_vdpa,
Si-Wei Liu <=
- [PATCH v4 4/7] vhost-net: fix improper cleanup in vhost_net_start, Si-Wei Liu, 2022/05/06
- [PATCH v4 2/7] virtio-net: align ctrl_vq index for non-mq guest for vhost_vdpa, Si-Wei Liu, 2022/05/06
- [PATCH v4 5/7] vhost-vdpa: backend feature should set only once, Si-Wei Liu, 2022/05/06
- [PATCH v4 7/7] virtio-net: don't handle mq request in userspace handler for vhost-vdpa, Si-Wei Liu, 2022/05/06
- [PATCH v4 6/7] vhost-vdpa: change name and polarity for vhost_vdpa_one_time_request(), Si-Wei Liu, 2022/05/06