Re: [PATCH v3] Warn user if the vga flag is passed but no vga device is created

[Peter Maydell]

On Fri, 6 May 2022 at 15:32, Thomas Huth <thuth@redhat.com> wrote:
>
> On 06/05/2022 16.24, Stefan Hajnoczi wrote:
> > On Sun, May 01, 2022 at 05:55:05PM +0530, Gautam Agrawal wrote:
> >> A global boolean variable "vga_interface_created"(declared in 
> >> softmmu/globals.c)
> >> has been used to track the creation of vga interface. If the vga flag is 
> >> passed
> >> in the command line "default_vga"(declared in softmmu/vl.c) variable is 
> >> set to 0.
> >> To warn user, the condition checks if vga_interface_created is false
> >> and default_vga is equal to 0. If "-vga none" is passed, this patch will 
> >> not warn the
> >> user regarding the creation of VGA device.
> >>
> >> The warning "A -vga option was passed but this
> >> machine type does not use that option; no VGA device has been created"
> >> is logged if vga flag is passed but no vga device is created.
> >>
> >> This patch has been tested for x86_64, i386, sparc, sparc64 and arm boards.
> >>
> >> Signed-off-by: Gautam Agrawal <gautamnagrawal@gmail.com>
> >> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/581
> >> ---
> >>   hw/hppa/machine.c         | 1 +
> >>   hw/isa/isa-bus.c          | 1 +
> >>   hw/mips/fuloong2e.c       | 1 +
> >>   hw/pci/pci.c              | 1 +
> >>   hw/ppc/spapr.c            | 1 +
> >>   hw/sparc/sun4m.c          | 2 ++
> >>   hw/sparc64/sun4u.c        | 1 +
> >>   hw/xenpv/xen_machine_pv.c | 1 +
> >>   include/sysemu/sysemu.h   | 1 +
> >>   softmmu/globals.c         | 1 +
> >>   softmmu/vl.c              | 6 ++++++
> >>   11 files changed, 17 insertions(+)
> >
> > Gerd or Richard: do you want to merge this patch?
>
> I'm just in progress of preparing a pull request with misc patches, I can
> also throw it in there if nobody minds.

Paolo mentioned on IRC yesterday that there was some detail he thought
it wasn't handling right with VGA_DEVICE, but I didn't really understand
the details. Paolo ?

thanks
-- PMM