[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 20/50] dino: use numerical constant for iar0 and iar1 reset va
From: |
Mark Cave-Ayland |
Subject: |
[PATCH v2 20/50] dino: use numerical constant for iar0 and iar1 reset values |
Date: |
Wed, 4 May 2022 10:25:30 +0100 |
This is to allow us to decouple the DINO device from the board logic. The choice
of using a hard-coded constant (along with a comment) is to match how this is
already done for toc_addr. If it is decided later that these values need to be
configurable then they can easily be converted to qdev properties.
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Acked-by: Helge Deller <deller@gmx.de>
---
hw/hppa/dino.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/hppa/dino.c b/hw/hppa/dino.c
index 6d12c385aa..aa7f812e22 100644
--- a/hw/hppa/dino.c
+++ b/hw/hppa/dino.c
@@ -403,7 +403,7 @@ static void dino_pcihost_reset(DeviceState *dev)
{
DinoState *s = DINO_PCI_HOST_BRIDGE(dev);
- s->iar0 = s->iar1 = CPU_HPA + 3;
+ s->iar0 = s->iar1 = 0xFFFB0000 + 3; /* CPU_HPA + 3 */
s->toc_addr = 0xFFFA0030; /* IO_COMMAND of CPU */
}
--
2.20.1
- Re: [PATCH v2 13/50] dino: change dino_init() to return the DINO device instead of PCIBus, (continued)
- [PATCH v2 15/50] dino.h: add defines for DINO IRQ numbers, Mark Cave-Ayland, 2022/05/04
- [PATCH v2 18/50] dino: remove unused dino_set_timer_irq() IRQ handler, Mark Cave-Ayland, 2022/05/04
- [PATCH v2 12/50] hppa: use new CONFIG_HPPA_B160L option instead of CONFIG_DINO to build hppa machine, Mark Cave-Ayland, 2022/05/04
- [PATCH v2 16/50] dino: define IRQ inputs as qdev GPIOs, Mark Cave-Ayland, 2022/05/04
- [PATCH v2 20/50] dino: use numerical constant for iar0 and iar1 reset values,
Mark Cave-Ayland <=
- [PATCH v2 19/50] hppa: move dino_init() from dino.c to machine.c, Mark Cave-Ayland, 2022/05/04
- [PATCH v2 21/50] dino: move DINO HPA constants from hppa_hardware.h to dino.h, Mark Cave-Ayland, 2022/05/04
- [PATCH v2 23/50] lasi: checkpatch fixes, Mark Cave-Ayland, 2022/05/04
- [PATCH v2 22/50] dino: move from hw/hppa to hw/pci-host, Mark Cave-Ayland, 2022/05/04
- [PATCH v2 24/50] lasi: move memory region initialisation to new lasi_init() function, Mark Cave-Ayland, 2022/05/04