qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 44/86] hppa: use memdev for RAM


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 44/86] hppa: use memdev for RAM
Date: Tue, 31 Dec 2019 16:45:27 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 12/31/19 2:03 PM, Igor Mammedov wrote:
memory_region_allocate_system_memory() API is going away, so
replace it with memdev allocated MemoryRegion. The later is
initialized by generic code, so board only needs to opt in
to memdev scheme by providing
   MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing
RAM memory region.

Signed-off-by: Igor Mammedov <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>

---
  hw/hppa/machine.c | 8 ++------
  1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c
index 25f5afc..b2f7bc5 100644
--- a/hw/hppa/machine.c
+++ b/hw/hppa/machine.c
@@ -70,7 +70,6 @@ static void machine_hppa_init(MachineState *machine)
      uint64_t kernel_entry = 0, kernel_low, kernel_high;
      MemoryRegion *addr_space = get_system_memory();
      MemoryRegion *rom_region;
-    MemoryRegion *ram_region;
      MemoryRegion *cpu_region;
      long i;
      unsigned int smp_cpus = machine->smp.cpus;
@@ -96,11 +95,7 @@ static void machine_hppa_init(MachineState *machine)
          exit(EXIT_FAILURE);
      }
- /* Main memory region. */
-    ram_region = g_new(MemoryRegion, 1);
-    memory_region_allocate_system_memory(ram_region, OBJECT(machine),
-                                         "ram", ram_size);
-    memory_region_add_subregion(addr_space, 0, ram_region);
+    memory_region_add_subregion(addr_space, 0, machine->ram);
/* Init Dino (PCI host bus chip). */
      pci_bus = dino_init(addr_space, &rtc_irq, &serial_irq);
@@ -284,6 +279,7 @@ static void machine_hppa_machine_init(MachineClass *mc)
      mc->is_default = 1;
      mc->default_ram_size = 512 * MiB;
      mc->default_boot_order = "cd";
+    mc->default_ram_id = "ram";
  }
DEFINE_MACHINE("hppa", machine_hppa_machine_init)





reply via email to

[Prev in Thread] Current Thread [Next in Thread]