Re: [PATCH v3 08/29] linux-user: Include trace-root.h in syscall-trace.h

[Philippe Mathieu-Daudé]

On 12/29/19 12:11 AM, Richard Henderson wrote:
> Code movement in an upcoming patch will show that this file
> was implicitly depending on trace-root.h being included beforehand.

The inlined functions call trace_guest_user_syscall[_ret] which are 
indeed declared in the root trace-events file:

trace-events:174:vcpu guest_user_syscall(uint64_t num, ...
trace-events:183:vcpu guest_user_syscall_ret(uint64_t num, ...

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> Reviewed-by: Alex Bennée <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>   include/user/syscall-trace.h | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/include/user/syscall-trace.h b/include/user/syscall-trace.h
> index 9e60473643..79fd3e5aa9 100644
> --- a/include/user/syscall-trace.h
> +++ b/include/user/syscall-trace.h
> @@ -10,6 +10,8 @@
>   #ifndef _SYSCALL_TRACE_H_
>   #define _SYSCALL_TRACE_H_
>   
> +#include "trace-root.h"
> +
>   /*
>    * These helpers just provide a common place for the various
>    * subsystems that want to track syscalls to put their hooks in. We