Re: [PATCH v3 07/29] linux-user: Include tcg.h in syscall.c

[Philippe Mathieu-Daudé]

On 12/29/19 12:11 AM, Richard Henderson wrote:
> Code movement in an upcoming patch will show that this file
> was implicitly depending on tcg.h being included indirectly.

Yes, it uses tcg_register_thread().

> Reviewed-by: Alex Bennée <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>   linux-user/syscall.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 171c0caef3..34825f15bf 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -115,6 +115,7 @@
>   #include "user/syscall-trace.h"
>   #include "qapi/error.h"
>   #include "fd-trans.h"
> +#include "tcg.h"

Since tcg origin (57fec1fee94) we use -I$(SRC_PATH)/tcg.

$ git grep -F '#include "tcg.h"'|wc -l
16
$ git grep -F '#include "tcg/tcg.h"'|wc -l
19

IMO using "tcg/tcg.h" is cleaner.

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

>   
>   #ifndef CLONE_IO
>   #define CLONE_IO                0x80000000      /* Clone io context */