Re: [PATCH v2 04/28] cputlb: Move body of cpu_ldst

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 04/28] cputlb: Move body of cpu_ldst_template.h out of lin

From:	Richard Henderson
Subject:	Re: [PATCH v2 04/28] cputlb: Move body of cpu_ldst_template.h out of line
Date:	Sun, 29 Dec 2019 07:50:14 +1100
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 12/21/19 5:36 AM, Alex Bennée wrote:
>> -#if !defined(SOFTMMU_CODE_ACCESS)
>> -#include "trace-root.h"
>> -#endif
>> -
>> -#include "qemu/plugin.h"
>> -#include "trace/mem.h"
> 
> I think api.c needs to include trace/mem.h

Yep, thanks.  I'll enable travis for my local branches for next time, which I
believe would have caught this.

r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v2 02/28] cputlb: Use trace_mem_get_info instead of trace_mem_build_info, (continued)
- [PATCH v2 02/28] cputlb: Use trace_mem_get_info instead of trace_mem_build_info, Richard Henderson, 2019/12/16
  - Re: [PATCH v2 02/28] cputlb: Use trace_mem_get_info instead of trace_mem_build_info, Philippe Mathieu-Daudé, 2019/12/16
  - Re: [PATCH v2 02/28] cputlb: Use trace_mem_get_info instead of trace_mem_build_info, Alex Bennée, 2019/12/20
- [PATCH v2 03/28] trace: Remove trace_mem_build_info_no_se_[bl]e, Richard Henderson, 2019/12/16
  - Re: [PATCH v2 03/28] trace: Remove trace_mem_build_info_no_se_[bl]e, Alex Bennée, 2019/12/20
    - Re: [PATCH v2 03/28] trace: Remove trace_mem_build_info_no_se_[bl]e, Richard Henderson, 2019/12/28
- [PATCH v2 04/28] cputlb: Move body of cpu_ldst_template.h out of line, Richard Henderson, 2019/12/16
  - Re: [PATCH v2 04/28] cputlb: Move body of cpu_ldst_template.h out of line, Alex Bennée, 2019/12/20
    - Re: [PATCH v2 04/28] cputlb: Move body of cpu_ldst_template.h out of line, Alex Bennée, 2019/12/20
  - Re: [PATCH v2 04/28] cputlb: Move body of cpu_ldst_template.h out of line, Alex Bennée, 2019/12/20
    - Re: [PATCH v2 04/28] cputlb: Move body of cpu_ldst_template.h out of line, Richard Henderson <=
- [PATCH v2 05/28] translator: Use cpu_ld*_code instead of open-coding, Richard Henderson, 2019/12/16
  - Re: [PATCH v2 05/28] translator: Use cpu_ld*_code instead of open-coding, Alex Bennée, 2019/12/20
- [PATCH v2 06/28] cputlb: Rename helper_ret_ld*_cmmu to cpu_ld*_code, Richard Henderson, 2019/12/16
  - Re: [PATCH v2 06/28] cputlb: Rename helper_ret_ld*_cmmu to cpu_ld*_code, Alex Bennée, 2019/12/20
    - Re: [PATCH v2 06/28] cputlb: Rename helper_ret_ld*_cmmu to cpu_ld*_code, Richard Henderson, 2019/12/28
- [PATCH v2 07/28] cputlb: Provide cpu_(ld, st}*_mmuidx_ra for user-only, Richard Henderson, 2019/12/16
  - Re: [PATCH v2 07/28] cputlb: Provide cpu_(ld, st}*_mmuidx_ra for user-only, Alex Bennée, 2019/12/20
- [PATCH v2 08/28] target/i386: Use cpu_*_mmuidx_ra instead of templates, Richard Henderson, 2019/12/16
  - Re: [PATCH v2 08/28] target/i386: Use cpu_*_mmuidx_ra instead of templates, Alex Bennée, 2019/12/20
    - Re: [PATCH v2 08/28] target/i386: Use cpu_*_mmuidx_ra instead of templates, Richard Henderson, 2019/12/28

Prev by Date: Re: [PATCH v2 03/28] trace: Remove trace_mem_build_info_no_se_[bl]e
Next by Date: Re: [PATCH v2 06/28] cputlb: Rename helper_ret_ld*_cmmu to cpu_ld*_code
Previous by thread: Re: [PATCH v2 04/28] cputlb: Move body of cpu_ldst_template.h out of line
Next by thread: [PATCH v2 05/28] translator: Use cpu_ld*_code instead of open-coding
Index(es):
- Date
- Thread