qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/5] python/qemu: qmp: Make accept()'s timeout configurable


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 3/5] python/qemu: qmp: Make accept()'s timeout configurable
Date: Fri, 27 Dec 2019 20:07:18 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 12/27/19 2:40 PM, Wainer dos Santos Moschetta wrote:
Currently the timeout of QEMUMonitorProtocol.accept() is
hard-coded to 15 seconds. This added the parameter `timeout`
so the value can be configured by the user.

Signed-off-by: Wainer dos Santos Moschetta <address@hidden>
---
  python/qemu/qmp.py | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/python/qemu/qmp.py b/python/qemu/qmp.py
index f4e04a6683..914b8c6774 100644
--- a/python/qemu/qmp.py
+++ b/python/qemu/qmp.py
@@ -154,16 +154,17 @@ class QEMUMonitorProtocol:
              return self.__negotiate_capabilities()
          return None
- def accept(self):
+    def accept(self, timeout=15):
          """
          Await connection from QMP Monitor and perform capabilities 
negotiation.
+ @param timeout (float): timeout in seconds. Default is 15.

Maybe name with unit: 'timeout_s'.

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

          @return QMP greeting dict
          @raise OSError on socket connection errors
          @raise QMPConnectError if the greeting is not received
          @raise QMPCapabilitiesError if fails to negotiate capabilities
          """
-        self.__sock.settimeout(15)
+        self.__sock.settimeout(timeout)
          self.__sock, _ = self.__sock.accept()
          self.__sockfile = self.__sock.makefile()
          return self.__negotiate_capabilities()





reply via email to

[Prev in Thread] Current Thread [Next in Thread]