[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] qapi/block: fix nbd-server-add spec
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH] qapi/block: fix nbd-server-add spec |
Date: |
Thu, 19 Dec 2019 17:34:15 +0300 |
"NAME" here may be interpreted like it should match @name, which is
export name. But it was never mentioned in such way. Make it obvious,
that actual "<dirty-bitmap-export-name>" (see docs/interop/nbd.txt)
will match @bitmap parameter.
Fixes: 5fcbeb06812685a2
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
Hi all.
This patch follows discussion on Nir's patch
[PATCH] block: nbd: Fix dirty bitmap context name
( https://lists.gnu.org/archive/html/qemu-devel/2019-12/msg04309.html )
Let's just fix qapi spec now.
qapi/block.json | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qapi/block.json b/qapi/block.json
index 145c268bb6..8042ef78f0 100644
--- a/qapi/block.json
+++ b/qapi/block.json
@@ -255,7 +255,8 @@
# @bitmap: Also export the dirty bitmap reachable from @device, so the
# NBD client can use NBD_OPT_SET_META_CONTEXT with
-# "qemu:dirty-bitmap:NAME" to inspect the bitmap. (since 4.0)
+# "qemu:dirty-bitmap:BITMAP" to inspect the bitmap (BITMAP here
+# matches @bitmap parameter). (since 4.0)
#
# Returns: error if the server is not running, or export with the same name
# already exists.
--
2.21.0
- [PATCH] qapi/block: fix nbd-server-add spec,
Vladimir Sementsov-Ogievskiy <=
- Re: [PATCH] qapi/block: fix nbd-server-add spec, Nir Soffer, 2019/12/19
- Re: [PATCH] qapi/block: fix nbd-server-add spec, Vladimir Sementsov-Ogievskiy, 2019/12/19
- Re: [PATCH] qapi/block: fix nbd-server-add spec, Nir Soffer, 2019/12/19
- Re: [PATCH] qapi/block: fix nbd-server-add spec, Vladimir Sementsov-Ogievskiy, 2019/12/19
- Re: [PATCH] qapi/block: fix nbd-server-add spec, Nir Soffer, 2019/12/19
- Re: [PATCH] qapi/block: fix nbd-server-add spec, Vladimir Sementsov-Ogievskiy, 2019/12/20
- Re: [PATCH] qapi/block: fix nbd-server-add spec, Eric Blake, 2019/12/20
- Re: [PATCH] qapi/block: fix nbd-server-add spec, Vladimir Sementsov-Ogievskiy, 2019/12/25
- Re: [PATCH] qapi/block: fix nbd-server-add spec, Eric Blake, 2019/12/20