Re: [PULL 00/62] Misc patches for 2019-12-16

[Juan Quintela]

Paolo Bonzini <address@hidden> wrote:
> On 18/12/19 09:54, Juan Quintela wrote:
>> "Dr. David Alan Gilbert" <address@hidden> wrote:
>>>> (and others similar)
>>>>
>>>> and in the migration-test:
>>>> MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
>>>> QTEST_QEMU_BINARY=i386-softmmu/qemu-system-i386
>>>> QTEST_QEMU_IMG=qemu-img tests/migration-test -m=quick -k --tap <
>>>> /dev/null | ./scripts/tap-driver.pl --test-name="migration-test"
>>>> PASS 1 migration-test /i386/migration/deprecated
>>>> /home/petmay01/linaro/qemu-for-merges/tests/migration-test.c:689:15:
>>>> runtime error: load of value 255, which is not a valid value for type
>>>> 'bool'
>>>> /home/petmay01/linaro/qemu-for-merges/tests/migration-test.c:690:16:
>>>> runtime error: null pointer passed as argument 1, which is declared to
>>>> never be null
>>>> /usr/include/unistd.h:828:48: note: nonnull attribute specified here
>>>
>>> That's a use-after-free from Juan's 'migration-test: Use a struct for
>>> test_migrate_start parameters';  it's calling migrate_start_destroy and
>>> then checks args->use_shmem.
>> 
>> Hi
>> 
>> New series with the fix posted upstream.
>> 
>> Paolo, should I did the pull requset, or will you do it?
>
> I can do it.

Thanks

>> PD.  Just curious, how should I launch clang to give me that error?
>
> "make docker-test-debug@fedora".

Double thanks.

Later, Juan.