[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v2 5/6] hw/net/imx_fec: Remove unuseful FALLTHROUGH comme
From: |
Thomas Huth |
Subject: |
Re: [RFC PATCH v2 5/6] hw/net/imx_fec: Remove unuseful FALLTHROUGH comments |
Date: |
Wed, 18 Dec 2019 20:28:31 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 18/12/2019 20.25, Philippe Mathieu-Daudé wrote:
> We don't need to explicit these obvious switch fall through
> comments. Stay consistent with the rest of the codebase.
>
> Suggested-by: Thomas Huth <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
...
> diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c
> index c01ce4f078..5a83678f64 100644
> --- a/hw/net/imx_fec.c
> +++ b/hw/net/imx_fec.c
> @@ -901,8 +901,8 @@ static void imx_eth_write(void *opaque, hwaddr offset,
> uint64_t value,
> s->regs[index] = 0;
> }
> break;
> - case ENET_TDAR1: /* FALLTHROUGH */
> - case ENET_TDAR2: /* FALLTHROUGH */
> + case ENET_TDAR1:
> + case ENET_TDAR2:
> if (unlikely(single_tx_ring)) {
> qemu_log_mask(LOG_GUEST_ERROR,
> "[%s]%s: trying to access TDAR2 or TDAR1\n",
Reviewed-by: Thomas Huth <address@hidden>
- [PATCH v2 0/6] Fix more GCC9 -O3 warnings, Philippe Mathieu-Daudé, 2019/12/18
- [PATCH v2 1/6] audio/audio: Add missing fall through comment, Philippe Mathieu-Daudé, 2019/12/18
- [PATCH v2 2/6] hw/display/tcx: Add missing fall through comments, Philippe Mathieu-Daudé, 2019/12/18
- [PATCH v2 4/6] hw/net/imx_fec: Rewrite fall through comments, Philippe Mathieu-Daudé, 2019/12/18
- [PATCH v2 3/6] hw/timer/aspeed_timer: Add a fall through comment, Philippe Mathieu-Daudé, 2019/12/18
- [RFC PATCH v2 5/6] hw/net/imx_fec: Remove unuseful FALLTHROUGH comments, Philippe Mathieu-Daudé, 2019/12/18
- [RFC PATCH v2 6/6] hw/pci-host/designware: Remove unuseful FALLTHROUGH comment, Philippe Mathieu-Daudé, 2019/12/18