[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] block/io: take bs->reqs_lock in bdrv_mark_request_serial
From: |
Kevin Wolf |
Subject: |
Re: [PATCH 3/3] block/io: take bs->reqs_lock in bdrv_mark_request_serialising |
Date: |
Wed, 18 Dec 2019 17:59:00 +0100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
Am 18.12.2019 um 14:17 hat Paolo Bonzini geschrieben:
> bdrv_mark_request_serialising is writing the overlap_offset and
> overlap_bytes fields of BdrvTrackedRequest. Take bs->reqs_lock
> for the whole direction of it, and not just when waiting for
Is "direction" really the word you meant?
> serialising requests, so that tracked_request_overlaps does not
> look at a half-updated request.
>
> The new code does not unlock/relock around retries. This is unnecessary
> because a retry is always preceded by a CoQueue wait, which already
> releases and reacquired bs->reqs_lock.
>
> Reported-by: Peter Lieven <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>