[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] multifd: Make sure that we don't do any IO after an erro
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH 2/4] multifd: Make sure that we don't do any IO after an error |
Date: |
Wed, 18 Dec 2019 13:57:54 +0000 |
User-agent: |
Mutt/1.13.0 (2019-11-30) |
* Juan Quintela (address@hidden) wrote:
> Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
I wonder if the fflush's should happen anyway?
> ---
> migration/ram.c | 22 +++++++++++++---------
> 1 file changed, 13 insertions(+), 9 deletions(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index db90237977..4b44578e57 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -4132,7 +4132,7 @@ static int ram_save_iterate(QEMUFile *f, void *opaque)
> {
> RAMState **temp = opaque;
> RAMState *rs = *temp;
> - int ret;
> + int ret = 0;
> int i;
> int64_t t0;
> int done = 0;
> @@ -4203,12 +4203,14 @@ static int ram_save_iterate(QEMUFile *f, void *opaque)
> ram_control_after_iterate(f, RAM_CONTROL_ROUND);
>
> out:
> - multifd_send_sync_main(rs);
> - qemu_put_be64(f, RAM_SAVE_FLAG_EOS);
> - qemu_fflush(f);
> - ram_counters.transferred += 8;
> + if (ret >= 0) {
> + multifd_send_sync_main(rs);
> + qemu_put_be64(f, RAM_SAVE_FLAG_EOS);
> + qemu_fflush(f);
> + ram_counters.transferred += 8;
>
> - ret = qemu_file_get_error(f);
> + ret = qemu_file_get_error(f);
> + }
> if (ret < 0) {
> return ret;
> }
> @@ -4260,9 +4262,11 @@ static int ram_save_complete(QEMUFile *f, void *opaque)
> ram_control_after_iterate(f, RAM_CONTROL_FINISH);
> }
>
> - multifd_send_sync_main(rs);
> - qemu_put_be64(f, RAM_SAVE_FLAG_EOS);
> - qemu_fflush(f);
> + if (ret >= 0) {
> + multifd_send_sync_main(rs);
> + qemu_put_be64(f, RAM_SAVE_FLAG_EOS);
> + qemu_fflush(f);
> + }
>
> return ret;
> }
> --
> 2.23.0
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK