qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PULL 56/87] hw/i386/pc: Use TYPE_PORT92 instead of hardcoded string


From: Paolo Bonzini
Subject: [PULL 56/87] hw/i386/pc: Use TYPE_PORT92 instead of hardcoded string
Date: Wed, 18 Dec 2019 13:02:22 +0100

From: Philippe Mathieu-Daudé <address@hidden>

By using the TYPE_* definitions for devices, we can:
- quickly find where devices are used with 'git-grep'
- easily rename a device (one-line change).

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
 hw/i386/pc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index ea7320b..67fddcc 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1278,7 +1278,7 @@ static void pc_superio_init(ISABus *isa_bus, bool 
create_fdctrl, bool no_vmport)
         qdev_prop_set_ptr(dev, "ps2_mouse", i8042);
         qdev_init_nofail(dev);
     }
-    port92 = isa_create_simple(isa_bus, "port92");
+    port92 = isa_create_simple(isa_bus, TYPE_PORT92);
 
     a20_line = qemu_allocate_irqs(handle_a20_line_change, first_cpu, 2);
     i8042_setup_a20_line(i8042, a20_line[0]);
-- 
1.8.3.1





reply via email to

[Prev in Thread] Current Thread [Next in Thread]