[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 00/62] Misc patches for 2019-12-16
From: |
Juan Quintela |
Subject: |
Re: [PULL 00/62] Misc patches for 2019-12-16 |
Date: |
Wed, 18 Dec 2019 09:54:48 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
"Dr. David Alan Gilbert" <address@hidden> wrote:
>> (and others similar)
>>
>> and in the migration-test:
>> MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
>> QTEST_QEMU_BINARY=i386-softmmu/qemu-system-i386
>> QTEST_QEMU_IMG=qemu-img tests/migration-test -m=quick -k --tap <
>> /dev/null | ./scripts/tap-driver.pl --test-name="migration-test"
>> PASS 1 migration-test /i386/migration/deprecated
>> /home/petmay01/linaro/qemu-for-merges/tests/migration-test.c:689:15:
>> runtime error: load of value 255, which is not a valid value for type
>> 'bool'
>> /home/petmay01/linaro/qemu-for-merges/tests/migration-test.c:690:16:
>> runtime error: null pointer passed as argument 1, which is declared to
>> never be null
>> /usr/include/unistd.h:828:48: note: nonnull attribute specified here
>
> That's a use-after-free from Juan's 'migration-test: Use a struct for
> test_migrate_start parameters'; it's calling migrate_start_destroy and
> then checks args->use_shmem.
Hi
New series with the fix posted upstream.
Paolo, should I did the pull requset, or will you do it?
Thanks, Juan.
PD. Just curious, how should I launch clang to give me that error?
- [PULL 54/62] hw/i386: Simplify ioapic_init_gsi(), (continued)
- [PULL 54/62] hw/i386: Simplify ioapic_init_gsi(), Paolo Bonzini, 2019/12/16
- [PULL 55/62] hw/isa/isa-bus: cleanup irq functions, Paolo Bonzini, 2019/12/16
- [PULL 59/62] hyperv: Use auto rcu_read macros, Paolo Bonzini, 2019/12/16
- [PULL 62/62] colo: fix return without releasing RCU, Paolo Bonzini, 2019/12/16
- [PULL 57/62] hw/i386/pc: Inline port92_init(), Paolo Bonzini, 2019/12/16
- [PULL 58/62] hw/i386/pc: Extract the port92 device, Paolo Bonzini, 2019/12/16
- [PULL 60/62] qsp: Use WITH_RCU_READ_LOCK_GUARD, Paolo Bonzini, 2019/12/16
- [PULL 61/62] memory: use RCU_READ_LOCK_GUARD, Paolo Bonzini, 2019/12/16
- Re: [PULL 00/62] Misc patches for 2019-12-16, Peter Maydell, 2019/12/17