|
From: | Richard Henderson |
Subject: | Re: [PATCH 2/6] hw/display/tcx: Add missing fall through comments |
Date: | Tue, 17 Dec 2019 17:57:36 -1000 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
On 12/17/19 7:34 AM, Philippe Mathieu-Daudé wrote: > GCC9 is confused by this comment when building with > CFLAG -Wimplicit-fallthrough=2: > > hw/display/tcx.c: In function ‘tcx_dac_writel’: > hw/display/tcx.c:453:26: error: this statement may fall through > [-Werror=implicit-fallthrough=] > 453 | s->dac_index = (s->dac_index + 1) & 0xff; /* Index > autoincrement */ > | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ > hw/display/tcx.c:454:9: note: here > 454 | default: > | ^~~~~~~ > hw/display/tcx.c: In function ‘tcx_dac_readl’: > hw/display/tcx.c:412:22: error: this statement may fall through > [-Werror=implicit-fallthrough=] > 412 | s->dac_index = (s->dac_index + 1) & 0xff; /* Index > autoincrement */ > | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ > hw/display/tcx.c:413:5: note: here > 413 | default: > | ^~~~~~~ > cc1: all warnings being treated as errors > > Add the missing fall through comments. > > Fixes: 55d7bfe22 > Signed-off-by: Philippe Mathieu-Daudé <address@hidden> > --- > Cc: Olivier Danet <address@hidden> > Cc: Mark Cave-Ayland <address@hidden> > --- > hw/display/tcx.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Richard Henderson <address@hidden> r~
[Prev in Thread] | Current Thread | [Next in Thread] |