[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v1 07/16] tests/hd-geo-test: Skip test when images can not be cre
From: |
Alex Bennée |
Subject: |
[PATCH v1 07/16] tests/hd-geo-test: Skip test when images can not be created |
Date: |
Mon, 16 Dec 2019 11:07:23 +0000 |
From: Thomas Huth <address@hidden>
In certain environments like restricted containers, we can not create
huge test images. To be able to use "make check" in such container
environments, too, let's skip the hd-geo-test instead of failing when
the test images could not be created.
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Message-Id: <address@hidden>
---
tests/hd-geo-test.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c
index 7e86c5416cc..a2498005440 100644
--- a/tests/hd-geo-test.c
+++ b/tests/hd-geo-test.c
@@ -34,8 +34,13 @@ static char *create_test_img(int secs)
fd = mkstemp(template);
g_assert(fd >= 0);
ret = ftruncate(fd, (off_t)secs * 512);
- g_assert(ret == 0);
close(fd);
+
+ if (ret) {
+ free(template);
+ template = NULL;
+ }
+
return template;
}
@@ -934,6 +939,10 @@ int main(int argc, char **argv)
for (i = 0; i < backend_last; i++) {
if (img_secs[i] >= 0) {
img_file_name[i] = create_test_img(img_secs[i]);
+ if (!img_file_name[i]) {
+ g_test_message("Could not create test images.");
+ goto test_add_done;
+ }
} else {
img_file_name[i] = NULL;
}
@@ -965,6 +974,7 @@ int main(int argc, char **argv)
"skipping hd-geo/override/* tests");
}
+test_add_done:
ret = g_test_run();
for (i = 0; i < backend_last; i++) {
--
2.20.1
- [PATCH v1 00/16] testing and logging changes for master, Alex Bennée, 2019/12/16
- [PATCH v1 01/16] configure: allow disable of cross compilation containers, Alex Bennée, 2019/12/16
- [PATCH v1 02/16] tests/vm: Allow to set qemu-img path, Alex Bennée, 2019/12/16
- [PATCH v1 03/16] travis.yml: Run tcg tests with tci, Alex Bennée, 2019/12/16
- [PATCH v1 04/16] iotests: Provide a function for checking the creation of huge files, Alex Bennée, 2019/12/16
- [PATCH v1 05/16] iotests: Skip test 060 if it is not possible to create large files, Alex Bennée, 2019/12/16
- [PATCH v1 06/16] iotests: Skip test 079 if it is not possible to create large files, Alex Bennée, 2019/12/16
- [PATCH v1 07/16] tests/hd-geo-test: Skip test when images can not be created,
Alex Bennée <=
- [PATCH v1 08/16] tests/test-util-filemonitor: Skip test on non-x86 Travis containers, Alex Bennée, 2019/12/16
- [PATCH v1 10/16] ci: build out-of-tree, Alex Bennée, 2019/12/16
- [PATCH v1 11/16] Fix double free issue in qemu_set_log_filename()., Alex Bennée, 2019/12/16
- [PATCH v1 09/16] travis.yml: Enable builds on arm64, ppc64le and s390x, Alex Bennée, 2019/12/16
- [PATCH v1 13/16] Add a mutex to guarantee single writer to qemu_logfile handle., Alex Bennée, 2019/12/16
- [PATCH v1 16/16] Added tests for close and change of logfile., Alex Bennée, 2019/12/16
- [PATCH v1 12/16] Cleaned up flow of code in qemu_set_log(), to simplify and clarify., Alex Bennée, 2019/12/16
- [PATCH v1 15/16] Add use of RCU for qemu_logfile., Alex Bennée, 2019/12/16
- [PATCH v1 14/16] qemu_log_lock/unlock now preserves the qemu_logfile handle., Alex Bennée, 2019/12/16