[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/8] hw/arm/raspi: Use memory_region_add_subregion() when priorit
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 2/8] hw/arm/raspi: Use memory_region_add_subregion() when priority is 0 |
Date: |
Sat, 14 Dec 2019 16:56:08 +0100 |
It is pointless to overlap a memory subregion with priority 0.
Use the simpler memory_region_add_subregion() function.
This patch was produced with the following spatch script:
@@
expression region;
expression offset;
expression subregion;
@@
-memory_region_add_subregion_overlap(region, offset, subregion, 0)
+memory_region_add_subregion(region, offset, subregion)
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/arm/bcm2835_peripherals.c | 4 ++--
hw/arm/raspi.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c
index 17207ae07e..f792bd6bb1 100644
--- a/hw/arm/bcm2835_peripherals.c
+++ b/hw/arm/bcm2835_peripherals.c
@@ -160,8 +160,8 @@ static void bcm2835_peripherals_realize(DeviceState *dev,
Error **errp)
for (n = 0; n < 4; n++) {
memory_region_init_alias(&s->ram_alias[n], OBJECT(s),
"bcm2835-gpu-ram-alias[*]", ram, 0, ram_size);
- memory_region_add_subregion_overlap(&s->gpu_bus_mr, (hwaddr)n << 30,
- &s->ram_alias[n], 0);
+ memory_region_add_subregion(&s->gpu_bus_mr, (hwaddr)n << 30,
+ &s->ram_alias[n]);
}
/* Interrupt Controller */
diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c
index 6a510aafc1..3649b75449 100644
--- a/hw/arm/raspi.c
+++ b/hw/arm/raspi.c
@@ -187,7 +187,7 @@ static void raspi_init(MachineState *machine, int version)
memory_region_allocate_system_memory(&s->ram, OBJECT(machine), "ram",
machine->ram_size);
/* FIXME: Remove when we have custom CPU address space support */
- memory_region_add_subregion_overlap(get_system_memory(), 0, &s->ram, 0);
+ memory_region_add_subregion(get_system_memory(), 0, &s->ram);
/* Setup the SOC */
object_property_add_const_link(OBJECT(&s->soc), "ram", OBJECT(&s->ram),
--
2.21.0
- [PATCH 0/8] Simplify memory_region_add_subregion_overlap(..., priority=0), Philippe Mathieu-Daudé, 2019/12/14
- [PATCH 8/8] target/i386/cpu: Use 'mr' for MemoryRegion variables, Philippe Mathieu-Daudé, 2019/12/14
- [PATCH 1/8] hw/arm/nrf51_soc: Use memory_region_add_subregion() when priority is 0, Philippe Mathieu-Daudé, 2019/12/14
- [PATCH 3/8] hw/arm/xlnx-versal: Use memory_region_add_subregion() when priority is 0, Philippe Mathieu-Daudé, 2019/12/14
- [PATCH 2/8] hw/arm/raspi: Use memory_region_add_subregion() when priority is 0,
Philippe Mathieu-Daudé <=
- [PATCH 6/8] hw/vfio/pci: Use memory_region_add_subregion() when priority is 0, Philippe Mathieu-Daudé, 2019/12/14
- [PATCH 5/8] hw/mips/boston: Use memory_region_add_subregion() when priority is 0, Philippe Mathieu-Daudé, 2019/12/14
- [PATCH 7/8] target/i386: Use memory_region_add_subregion() when priority is 0, Philippe Mathieu-Daudé, 2019/12/14
- [PATCH 4/8] hw/i386/intel_iommu: Use memory_region_add_subregion when priority is 0, Philippe Mathieu-Daudé, 2019/12/14
- Re: [PATCH 0/8] Simplify memory_region_add_subregion_overlap(..., priority=0), Peter Maydell, 2019/12/14
- Re: [PATCH 0/8] Simplify memory_region_add_subregion_overlap(..., priority=0), Michael S. Tsirkin, 2019/12/15