[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation
From: |
Finn Thain |
Subject: |
Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation |
Date: |
Sat, 14 Dec 2019 13:52:33 +1100 (AEDT) |
On Fri, 13 Dec 2019, address@hidden wrote:
> === OUTPUT BEGIN ===
> 1/10 Checking commit 9c9ffc38e9b9 (dp8393x: Mask EOL bit from descriptor
> addresses)
> ERROR: return is not a function, parentheses are not required
> #24: FILE: hw/net/dp8393x.c:200:
> + return (s->regs[SONIC_URDA] << 16) | (s->regs[SONIC_CRDA] & 0xfffe);
>
> ERROR: return is not a function, parentheses are not required
> #33: FILE: hw/net/dp8393x.c:220:
> + return (s->regs[SONIC_UTDA] << 16) | (s->regs[SONIC_TTDA] & 0xfffe);
>
I expect that checkpatch.pl has no idea about operator precedence, but
these parentheses could actually be omitted.
I kept them because I don't want readers to have to remember that bit
shift operator has higher precedence than bitwise OR operator, or look it
up if they don't.
The existing code also has those unnecessary parentheses.
Please let me know if this patch should include a code style change.
- [PATCH 06/10] dp8393x: Clear RRRA command register bit only when appropriate, (continued)
- [PATCH 06/10] dp8393x: Clear RRRA command register bit only when appropriate, Finn Thain, 2019/12/13
- [PATCH 02/10] dp8393x: Clean up endianness hacks, Finn Thain, 2019/12/13
- [PATCH 01/10] dp8393x: Mask EOL bit from descriptor addresses, Finn Thain, 2019/12/13
- [PATCH 03/10] dp8393x: Have dp8393x_receive() return the packet size, Finn Thain, 2019/12/13
- [PATCH 08/10] dp8393x: Implement packet size limit and RBAE interrupt, Finn Thain, 2019/12/13
- Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation, no-reply, 2019/12/13
- Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation,
Finn Thain <=
- Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation, Aleksandar Markovic, 2019/12/14
- Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation, Finn Thain, 2019/12/14
- Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation, Aleksandar Markovic, 2019/12/14
- Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation, Aleksandar Markovic, 2019/12/14
- Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation, Finn Thain, 2019/12/19
- Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation, Philippe Mathieu-Daudé, 2019/12/23
- NetBSD/arc on MIPS Magnum, was Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation, Finn Thain, 2019/12/23
- Re: NetBSD/arc on MIPS Magnum, was Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation, Finn Thain, 2019/12/23